Bug 803 - confusing (and incorrect) code comment in daemon_cleanup()
confusing (and incorrect) code comment in daemon_cleanup()
Status: RESOLVED FIXED
Product: unbound
Classification: Unclassified
Component: server
unspecified
Other All
: P5 minor
Assigned To: unbound team
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-07-22 03:35 CEST by JINMEI Tatuya
Modified: 2016-07-22 09:09 CEST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description JINMEI Tatuya 2016-07-22 03:35:47 CEST
This code comment in daemon/daemon.c:daemon_cleanup() is simply incorrect:

	/* key cache is cleared by module desetup during next daemon_init() */
	daemon_remote_clear(daemon->rc);

The key cache is actually cleared during next daemon_fork(), not daemon_init().

A trivial typo, but can be confusing unless you already know the code
very well, so it would be nice if it's corrected.
Comment 1 Wouter Wijngaards 2016-07-22 09:09:44 CEST
Hi Jinmei,

Thanks for the report.  Fixed the comment-bug.

Best regards, Wouter