Bug 654 - contradiction in notify logging verbosity level
contradiction in notify logging verbosity level
Status: RESOLVED FIXED
Product: NSD
Classification: Unclassified
Component: NSD Code
4.1.x
Other All
: P5 minor
Assigned To: NSD team
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-24 02:41 CET by howard.m.kash.civ
Modified: 2015-03-24 09:18 CET (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description howard.m.kash.civ 2015-03-24 02:41:21 CET
The logging of notifies has contradictory logging levels in the following block from query.c:

        if (verbosity >= 1) {
                char address[128];
                addr2str(&query->addr, address, sizeof(address));
                VERBOSITY(2, (LOG_INFO, "notify for zone %s from client %s refused, %s%s",
                        dname_to_string(query->qname, NULL),
                        address,
                        why?why->key_name:"no acl matches",
                        why?why->ip_address_spec:"."));
        }

The if clasuse says >= 1 but the VERBOSITY macro says >= 2.  I would like to see the VERBOSITY argument changed to 1 so that notifies are logged at a verbosity level of 1.
Comment 1 Wouter Wijngaards 2015-03-24 09:18:01 CET
Hi Howard,

Yes other notify information is printed at level 1.  Fixed, thanks for the detailed explanation.

Best regards,
   Wouter