Bug 206 - no need to use any grep when also using awk
no need to use any grep when also using awk
Status: RESOLVED FIXED
Product: unbound
Classification: Unclassified
Component: server
unspecified
Other All
: P2 minor
Assigned To: unbound team
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-13 00:57 CEST by Greg A. Woods
Modified: 2008-08-13 08:30 CEST (History)
1 user (show)

See Also:


Attachments
avoid unnecessary egrep process when using awk in iana_update (1001 bytes, patch)
2008-08-13 00:57 CEST, Greg A. Woods
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg A. Woods 2008-08-13 00:57:32 CEST
Created attachment 79 [details]
avoid unnecessary egrep process when using awk in iana_update

egrep is used unnecessarily in the iana_update target of the top-level Makefile.

(note the attached patch also shows how to use the NetBSD ftp to fetch the port-numbers file since the native ftp client has that ability, thus avoiding non-standard utilities -- NetBSD ftp is available for other systems and is already integrated as the native ftp client on a number of other systems)
Comment 1 Wouter Wijngaards 2008-08-13 08:30:38 CEST
Thanks! Applied to trunk.

my linux ftp doesn't work with http://, so I'll keep using curl.
If it were possible to detect NetBSD-ness of ftp easily, a shell if statement could be used to select ftp on NetBSD.

Anyway, awk is nicer, I'll close this bug.
Let me know of further improvements :-)

Best regards,
   Wouter