Bug 149 - RCODE 9 misrepresented in code and comment
RCODE 9 misrepresented in code and comment
Status: RESOLVED FIXED
Product: NSD
Classification: Unclassified
Component: NSD Code
3.0.x
All All
: P2 normal
Assigned To: NSD team
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-13 15:42 CEST by Peter Koch
Modified: 2006-10-13 16:14 CEST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Koch 2006-10-13 15:42:57 CEST
The DNS RCODE 9 is misrepresented as 'not authorized' in comment and code:
dns.h:#define RCODE_NOTAUTH             9       /* Not authorized */
util.c:const char*
rcode2str(int rc)
        case RCODE_NOTAUTH:
                return "NOT AUTHORIZED";

This should read "NOT AUTHORITATIVE" instead (see RFC 2136 or IANA dns-parameters registry).
I stumbled across this when playing with nsd-notify.
Comment 1 Wouter Wijngaards 2006-10-13 16:14:00 CEST
I have fixed the text description of the bug in code and printed text. When a notify fails to pass the access control list REFUSED is returned, not NOTAUTH(server not authoritative for zone). This is in svn for 3.0.2.

Backported the text fix to NSD 2.3.7 svn.