Bug 1213 - Python module: support multiple instances
Python module: support multiple instances
Status: ASSIGNED
Product: unbound
Classification: Unclassified
Component: server
1.7.0
All All
: P5 enhancement
Assigned To: unbound team
https://github.com/NLnetLabs/unbound/...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-01-27 19:54 CET by episource
Modified: 2018-05-02 11:09 CEST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description episource 2017-01-27 19:54:18 CET
Currently, it's not possible to use multiple instances of the python module. Actually, adding the word `python` to the `module-config:` option several times is not rejected by unbound. In the end, however, it's not a useable setup supported by unbound.

It happened to be quiet simple to prepare the python module for multiple instance support. @github I've prepared a feature branch proposing a possible solution. Please have a look at: https://github.com/episource/unbound/tree/dev/pythonmod-multi-instance/main

The proposed solution allows to reference the python module more than once within `module-config:` option. For each instance, a `python-script:` option needs to be added to the `python:` section, specifying the python script file to be used. The first python module picks up the first `python-script:` option, the second picks up the second script, and so on.
Comment 1 episource 2017-03-12 14:59:50 CET
Diff url has changed. The diff against current master can be found here:
https://github.com/episource/unbound/compare/master...episource:dev/pythonmod-multi-instance/master
Comment 2 episource 2018-05-01 13:18:50 CEST
I've created a github pull request for this: https://github.com/NLnetLabs/unbound/pull/6
Comment 3 George Thessalonikefs 2018-05-02 11:09:41 CEST
Hi episource,

We are willing to merge your code to unbound's source.
Currently we are releasing 1.7.1, so this code after internal review will be headed for the next release (probably 1.7.2).

Thanks for the contribution!

Best regards,
George